Add support for parsing designated protocols in operator declarations. #19145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2018 23:10
The support is gated by a frontend option, -enable-operator-designated-protocols. This means that in an operator declaration we can declare a protocol which has one or more requirements specifying this operator. The operators from that designated protocol will be the first ones we try when type checking an expression. If we successfully typecheck using the operators specified in that protocol, we do not attempt any other overloads of the same operator. This makes it possible to dramatically speed up successful typechecking.
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
|
Yeah, I don't think parsing two identifiers is a good idea. Instead, you should be parsing two TypeLocs, and deciding later if one of them is an identifier that names a precedence group. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support is gated by a frontend option, -enable-operator-designated-protocols.
This means that in an operator declaration we can declare a protocol
which has one or more requirements specifying this operator. The
operators from that designated protocol will be the first ones we try
when type checking an expression. If we successfully typecheck using
the operators specified in that protocol, we do not attempt any other
overloads of the same operator.
This makes it possible to dramatically speed up successful
typechecking.