Skip to content

Conversation

@gribozavr
Copy link
Contributor

@gribozavr gribozavr commented May 18, 2016

  • Explanation: Add Swift 2->3 migration aids for the new SetAlgebra API.
  • Scope of Issue: Affects users who paste Swift 2 code into a Swift 3 project.
  • Risk: low risk, only adds unavailable declarations.
  • Reviewed By: @moiseev.
  • Testing: manual.

rdar://problem/26340072


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
OS X platform @swift-ci Please test OS X platform
Linux platform @swift-ci Please test Linux platform

Note: Only members of the Apple organization can trigger swift-ci.

@gribozavr
Copy link
Contributor Author

@moiseev Could you review, please?

@gribozavr gribozavr changed the title stdlib: add migration aids for SetAlgebra API [swift-3.0-preview-1][stdlib] add migration aids for SetAlgebra API May 18, 2016
@moiseev
Copy link
Contributor

moiseev commented May 18, 2016

LGTM

@gribozavr gribozavr assigned tkremenek and unassigned moiseev May 18, 2016
@tkremenek
Copy link
Member

@swift-ci test

@tkremenek tkremenek merged commit 726b66a into swift-3.0-preview-1-branch May 19, 2016
@tkremenek tkremenek deleted the stdlib-setalgebra-migration-attributes branch May 19, 2016 05:23
@tkremenek
Copy link
Member

Reverted. Appears to be causing test failures:

https://ci.swift.org/job/oss-swift-3.0-preview-1-incremental-RA-linux-ubuntu-15_10/23/

@tkremenek
Copy link
Member

CI went good, mysteriously, on the next run. Re-applying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants