Skip to content

build: remove the Python 2 check#33651

Merged
compnerd merged 1 commit intoswiftlang:masterfrom
compnerd:complete
Aug 27, 2020
Merged

build: remove the Python 2 check#33651
compnerd merged 1 commit intoswiftlang:masterfrom
compnerd:complete

Conversation

@compnerd
Copy link
Copy Markdown
Member

The Swift build is now fully migrated to Python 3. Although it is
backwards/forwards compatible, the build invokes everything with the
Python3 interpreter, and the Python 2 interpreter should be unused.
Remove the last reference to it.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

The Swift build is now fully migrated to Python 3.  Although it is
backwards/forwards compatible, the build invokes everything with the
Python3 interpreter, and the Python 2 interpreter should be unused.
Remove the last reference to it.
@compnerd
Copy link
Copy Markdown
Member Author

@swift-ci please clean test

@compnerd
Copy link
Copy Markdown
Member Author

CC: @drexin @shahmishal

Copy link
Copy Markdown
Contributor

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

@swift-ci
Copy link
Copy Markdown
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 82e870b

@compnerd
Copy link
Copy Markdown
Member Author

@shahmishal seems that the macOS builders are missing flake8 again?

FAIL: Swift(macosx-x86_64) :: Python/python_lint.swift (7422 of 13687)
******************** TEST 'Swift(macosx-x86_64) :: Python/python_lint.swift' FAILED ********************
Script:
--
: 'RUN: at line 8';   /Applications/Xcode-beta.app/Contents/Developer/usr/bin/python3 /Users/buildnode/jenkins/workspace/swift-PR-osx/branch-master/swift/utils/python_lint.py
--
Exit Code: 1

Command Output (stdout):
--

The flake8 and flake8-import-order Python packages are required for linting,
but these were not found on your system.

You can install these using:

    python -m pip install flake8
    python -m pip install flake8-import-order

For more help, see http://flake8.pycqa.org.


--

@swift-ci
Copy link
Copy Markdown
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 82e870b

@compnerd
Copy link
Copy Markdown
Member Author

@swift-ci please test Linux platform

@shahmishal
Copy link
Copy Markdown
Member

@swift-ci test macOS

@shahmishal
Copy link
Copy Markdown
Member

@compnerd I fixed the issue with flake8 module, let me know if you see it again.

@swift-ci
Copy link
Copy Markdown
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 82e870b

@swift-ci
Copy link
Copy Markdown
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 82e870b

@CodaFi
Copy link
Copy Markdown
Contributor

CodaFi commented Aug 27, 2020

@swift-ci clean test

@swift-ci
Copy link
Copy Markdown
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 82e870b

@compnerd
Copy link
Copy Markdown
Member Author

@swift-ci please test Linux platform

@compnerd compnerd merged commit ce2377d into swiftlang:master Aug 27, 2020
@compnerd compnerd deleted the complete branch August 27, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants