IRGen: Create full async functions for partial apply forwarders #36700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
External async functions pointers can't be used to clone the async context size from. Future improvement: reinstate the previous optimization of reusing the context. rdar://76029017
Contributor
Author
|
@swift-ci Please test |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci Please smoke test macOS |
1 similar comment
Contributor
Author
|
@swift-ci Please smoke test macOS |
Contributor
Author
|
@swift-ci Please clean smoke test macOS |
1 similar comment
Contributor
Author
|
@swift-ci Please clean smoke test macOS |
DougGregor
reviewed
Apr 1, 2021
| asyncFunctionPtr = | ||
| emitAsyncFunctionPointer(IGM, fwd, entity, asyncLayout->getSize()); | ||
| // TODO: if calleeAFP is definition: | ||
| #if 0 |
Contributor
Author
There was a problem hiding this comment.
Yes. We will want to reinstate the old code conditionally later. This serves as a reminder for me how-to do it.
Contributor
Author
|
@swift-ci please test macOS |
Contributor
|
Build failed |
Contributor
Author
|
@swift-ci please test macOS |
nate-chandler
added a commit
to nate-chandler/swift
that referenced
this pull request
Apr 6, 2021
Previously, because partial apply forwarders for async functions were not themselves fully-fledged async functions, they were not able to handle dynamic functions. Specifically, the reason was that it was not possible to produce an async function pointer for the partial apply forwarder because the size to be used was not knowable. Thanks to swiftlang#36700, that cause has been eliminated. With it, partial apply forwarders are fully-fledged async functions and in particular have their own async function pointers. Consequently, it is again possible for these partial apply forwarders to handle non-constant function pointers. Here, that behavior is restored, by way of reverting part of ee63777 while preserving the ABI it introduced. rdar://76122027
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External async functions pointers can't be used to clone the async
context size from.
Future improvement: reinstate the previous optimization of reusing the
context.
rdar://76029017