[Concurrency] Add "async" operation for continuing work asynchronously.#37007
Merged
Conversation
This new attribute can be used on parameters of `@Sendable async` type to indicate that the closures arguments passed to such parameters should inherit the actor context where they are formed, which is not the normal behavior for `@Sendable` closures. Another part of rdar://76927008.
The `async` operation is a global function that initiates asynchronous work on behalf of the synchronous code that calls it. Unlike `detach`, `async` inherits priority, actor context, and other aspects of the synchronous code that initiates it, making it a better "default" operation for creating asynchronous work than `detach`. The `detach` operation is still important for creating truly detached tasks that can later be `await`'d or cancelled if needed. Implements the main entry point for rdar://76927008.
Member
Author
|
@swift-ci please test |
ktoso
reviewed
Apr 22, 2021
| return JobPriority::UserInitiated; | ||
|
|
||
| return static_cast<JobPriority>(qos_class_self()); | ||
| } |
ktoso
reviewed
Apr 22, 2021
| @available(macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, *) | ||
| public func async( | ||
| priority: Task.Priority = .unspecified, | ||
| @_inheritActorContext @_implicitSelfCapture operation: __owned @Sendable @escaping () async -> Void |
Contributor
There was a problem hiding this comment.
oh boy that's a lot of annotations, but love how precisely this expresses stuff :)
ktoso
reviewed
Apr 22, 2021
| } | ||
|
|
||
| return Task.Priority(rawValue: _getCurrentThreadPriority()) ?? .unspecified | ||
| } |
ktoso
approved these changes
Apr 22, 2021
Contributor
ktoso
left a comment
ktoso
left a comment
There was a problem hiding this comment.
Ah cool, not much magic at all then. Very nice 👍
I'll implement propagating locals through these once it merges 👍
ktoso
reviewed
Apr 22, 2021
| /// which thread is executing. | ||
| /// - operation: the operation to execute | ||
| @available(macOS 9999, iOS 9999, watchOS 9999, tvOS 9999, *) | ||
| public func async( |
Contributor
There was a problem hiding this comment.
Man... I'd really like a verb here; Isn't this a send?
spawn- make child task, will await itdetach- completely separate; could wait if one wanted to, carries no values/things implicitlysend- fire and forget, cannot await on the result; usable from sync code, does carry priority and locals <- this is exactly what doing a "fire and forget" message send would want to be, so I'm so tempted to call it a send...asyncis a bit weird and it's dispatch wording inheritance too..
It's three concepts but really seems like the "trinity" of things we'll ever need: waiting, not waiting, completely splitting off computation.
There was a problem hiding this comment.
Man... I'd really like a verb here; Isn't this a
send?
Nah, it's a dispatch ;-)
(yeah, gcd connotations I know, but one could say the same for send(2))
Contributor
|
Build failed |
JensAyton
reviewed
Apr 22, 2021
| /// Run given `operation` as asynchronously in its own top-level task. | ||
| /// | ||
| /// The `async` function should be used when creating asynchronous work | ||
| /// that operations on behalf of the synchronous function that calls it. |
Member
Author
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
asyncoperation is a global function that initiates asynchronouswork on behalf of the synchronous code that calls it. Unlike
detach,asyncinherits priority, actor context, and other aspects of thesynchronous code that initiates it, making it a better "default"
operation for creating asynchronous work than
detach. Thedetachoperation is still important for creating truly detached tasks that
can later be
await'd or cancelled if needed.Implements the main entry point for rdar://76927008.