Revert "ClangImporter: run Clang with a proper executable path" #37805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
CC: @egorzhdan @zoecarver |
Member
Author
|
@swift-ci please test |
zoecarver
approved these changes
Jun 5, 2021
Contributor
zoecarver
left a comment
zoecarver
left a comment
There was a problem hiding this comment.
Thanks for tracing this back. Maybe you can Egor can work together to figure out what the issue was and re-land it.
In the future, what's the swift-ci incantation to get it to run these tests that failed (or is there one even)?
Member
Author
|
There isn't one sadly, but you can always reproduce the builds locally if you like (all of the build infra for that is open in a separate repository) :) |
Contributor
|
Build failed |
Member
Author
|
@swift-ci please smoke test macOS platform |
1 similar comment
Member
Author
|
@swift-ci please smoke test macOS platform |
Contributor
|
Apologies for breaking the Windows build! I'll make it work for the standalone builds & will resubmit the patch later. |
egorzhdan
added a commit
to egorzhdan/swift
that referenced
this pull request
Jun 22, 2021
This change re-applies swiftlang#36749 after it has been reverted in swiftlang#37805 because of a broken standalone stdlib build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #36749
This is causing the standalone swift-stdlib builds to break and is blocking the Windows nightlies.