[TypeChecker] Enable result builder AST transform by default#60419
Closed
xedin wants to merge 8 commits intoswiftlang:mainfrom
Closed
[TypeChecker] Enable result builder AST transform by default#60419xedin wants to merge 8 commits intoswiftlang:mainfrom
xedin wants to merge 8 commits intoswiftlang:mainfrom
Conversation
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
5ea8a31 to
bcd2523
Compare
Contributor
There was a problem hiding this comment.
Typo?
Suggested change
| /// code compleiton token. | |
| /// code completion token. |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
bcd2523 to
c5a9974
Compare
Contributor
Author
|
@swift-ci please test |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
c5a9974 to
d769dab
Compare
Contributor
Author
|
@swift-ci please test |
1 similar comment
Contributor
Author
|
@swift-ci please test |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
648574f to
de77ccb
Compare
Contributor
Author
|
@swift-ci please test macOS platform |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
de77ccb to
2f83aee
Compare
Contributor
Author
|
@swift-ci please test macOS platform |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
2f83aee to
fafe5d7
Compare
Contributor
Author
|
@swift-ci please test macOS platform |
Contributor
Author
|
@swift-ci please build toolchain macOS |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
fafe5d7 to
ee4b580
Compare
Contributor
Author
|
@swift-ci please test |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
ee4b580 to
e18bee6
Compare
Contributor
Author
|
@swift-ci please build toolchain macOS platform |
1 similar comment
Contributor
Author
|
@swift-ci please build toolchain macOS platform |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
8cf36c7 to
db89915
Compare
Contributor
Author
|
@swift-ci please smoke test |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
02d6343 to
f8f0155
Compare
Contributor
Author
|
@swift-ci please smoke test |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
f8f0155 to
afe3d30
Compare
Contributor
Author
|
@swift-ci please smoke test macOS platform |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
afe3d30 to
48a0654
Compare
Contributor
Author
|
@swift-ci please smoke test |
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
48a0654 to
8eff924
Compare
Contributor
Author
|
@swift-ci please smoke test |
…tements Visiting of transformed `do` shouldn't run syntatic diagnostics because they are going to be performed by `visit` that called `visitDoStmt`.
…o retrieve contextual type rdar://94224692
…syntactic elements that don't contain completion token
- `buildCallIfNeeded` has been replaced with `buildCall` - SolverState has a "current indent" method now.
With AST transform enabled by default most of the previously invalid declarations became valid (due to SE-0373 being implemented only for AST transform).
xedin
force-pushed
the
enable-result-builder-ast-transform-by-default
branch
from
8eff924 to
f6de4be
Compare
Contributor
Author
|
@swift-ci please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
ResultBuilderASTTransform)Resolves: rdar://89880662
Resolves: rdar://97388257
Resolves: rdar://95235303
Resolves: rdar://96343005
Resolves: rdar://91731420
Resolves: rdar://95977761
Resolves: rdar://80680636