Local functions inherit isolation from context instead of captures #73129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of looking at captures, which wasn't sound with recursive local functions; we would look at the captures of the function currently being type checked, which are not available yet.
If the outer context is actor isolated, we need to force a capture the actor variable, since otherwise it might not appear in the capture list.
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test source compatibility |
hjyamauchi
added a commit
to hjyamauchi/swift
that referenced
this pull request
May 23, 2024
This PR builds on swiftlang#73129 and fixes swiftlang#73345. Co-authored with @hyp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we said a non-
@Sendablelocal function was actor isolated if it captured an isolated parameter. The new rule no longer looks at captures, instead we force a capture of the isolated parameter if the function's parent context is actor isolated.