[6.3][SILOptimizer] Transfer nonisolated(nonsending) from the original t…#89693
Merged
Conversation
…o specialized/optimized SILFunction variant This is a narrow fix for `nonisolated(nonsending)` function and reabstraction thunks in particular. If the speciflized/optimized variant doesn't get the right isolation, `OptimizeHopToExecutor` pass can incorrectly remove a valid backward hop which results in a potential runtime crash if the call to `nonisolated(nonsending)` is followed by synchronous code that expects the original isolation. Resolves: rdar://178397835
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test macOS platform |
hborla
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o specialized/optimized SILFunction variant
Explanation:
This is a narrow fix for
nonisolated(nonsending)function and reabstraction thunks in particular. If the speciflized/optimized variant doesn't get the right isolation,OptimizeHopToExecutorpass can incorrectly remove a valid backward hop which results in a potential runtime crash if the call tononisolated(nonsending)is followed by synchronous code that expects the original isolation.Resolves: rdar://178397835
Main Branch PRs: This is a 6.3 specific fix that is not required for 6.4/main because there isolation is assigned on
SILFunction{Type}construction.Risk: Very Low. The change is very narrow and apply only to specializations of
nonisolated(nonsending)declarations.Reviewed By: N/A
Testing: Added new test-cases to the suite.