Fix powerset sampling#181
Merged
Merged
Conversation
mdbenito
added
bug
mdbenito
requested review from
AnesBenmerzoug
and removed request for
AnesBenmerzoug
Collaborator
|
I had a quick look at the changes and this looks good to me. It's only missing an entry in the changelog. |
AnesBenmerzoug
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr undoes all the weird shit I did to sample from a powerset (wtf was all that about??) and changes the test to do something more natural to me, which is to check the frequencies at which elements (roughly 2**-n) and at which subset sizes (roughly comb(n,k) appear.
I also removed the distribution parameter because it was not being used and all MC sums use a uniform distribution. I know we have #121 but I think we can add any arguments / methods / classes later if needed.