Skip to content

Fix/cleanup#238

Merged
mdbenito merged 8 commits into
developfrom
fix/cleanup
Jan 12, 2023
Merged

Fix/cleanup#238
mdbenito merged 8 commits into
developfrom
fix/cleanup

Conversation

@mdbenito
Copy link
Copy Markdown
Collaborator

@mdbenito mdbenito commented Jan 8, 2023

This PR:

  • Improves some documentation
  • Adds references to after automodule in the doc templates (=> no longer need to add .. footbibliography:: in each method)
  • Syncs the bib with Zotero
  • Cleans some random things up
  • Deletes unused files for banzhaf (to be implemented in the semivalues module)

@mdbenito mdbenito added documentation Improvements or additions to documentation cleanup when code is ugly or unreadable and needs restyling labels Jan 8, 2023
@mdbenito mdbenito added this to the Ready for public release milestone Jan 8, 2023
Comment thread CONTRIBUTING.md Outdated
Comment thread src/pydvl/value/least_core/montecarlo.py Outdated
Comment thread src/pydvl/value/least_core/naive.py Outdated
Copy link
Copy Markdown
Collaborator

@AnesBenmerzoug AnesBenmerzoug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the 1 question and 2 comments I left, everything else looks good to me.

@mdbenito mdbenito self-assigned this Jan 9, 2023
@mdbenito mdbenito merged commit 372a341 into develop Jan 12, 2023
@mdbenito mdbenito deleted the fix/cleanup branch January 12, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup when code is ugly or unreadable and needs restyling documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants