add some settings to make docker devstack build #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a couple errors encountered while building the docker image for devstack
3 tasks
|
@thraxil Ax currently generates it for new deployments so I wouldn't worry about that. |
OmarIthawi
suggested changes
Nov 13, 2018
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
Thanks @thraxil! The PR looks good now. Please fix the merge conflicts in CHANGELOG.md
thraxil
force-pushed
the
docker-fixes
branch
from
c7f3010 to
3ef3c76
Compare
OmarIthawi
suggested changes
Nov 14, 2018
thraxil
force-pushed
the
docker-fixes
branch
from
3ef3c76 to
5d43e9f
Compare
OmarIthawi
approved these changes
Nov 15, 2018
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
@thraxil this is great! Thank you.
Let's get this merged!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple errors encountered while building the docker image for devstack
I set a default for
private_requirements_fileto the same as we set in our usual base settings.Is there a better way to make sure that the
EDXAPP_EDXAPP_SECRET_KEYvariable is defined but make sure that it definitely gets overridden in production setups? (for the purposes of getting devstack to build, I'm not worried about it).