add fix for custom domains in Tahoe 2.0 #410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
melvinsoft
requested review from
briandant,
bryanlandia and
thraxil
and removed request for
briandant
OmarIthawi
reviewed
Sep 14, 2022
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
I've reviewed the code quickly but I don't understand the change.
Would you mind explaining were the bug was?
thraxil
approved these changes
Sep 15, 2022
OmarIthawi
approved these changes
Sep 19, 2022
amirtds
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configuration Pull Request
This PR works together with: appsembler/edx-platform#1239
This changes how we query custom domains, before we use to get them from the AMC database, now we won't have AMC database anymore, so we take them from the AlternativeDomain model in edX platform, which is really messy, that causes that until a custom domain is activated, we won't get it in the list. This PRs adds it to the list when we are generating the cert for the domain itself.
This code is tested in staging and it works.