Trigger Sultan tests

[iamjazzar]

Change description

Run Sultan tests on this branch.

Type of change

• Bug fix (fixes an issue)
• New feature (adds functionality)

Checklists

Development

• Lint rules pass locally
• Application changes have been tested thoroughly
• Automated tests covering modified code pass

Security

• Security impact of change has been considered
• Code follows company security practices and guidelines

Code review

• Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
• "Ready for review" label attached and reviewers assigned
• Changes have been reviewed by at least one other contributor
• Pull request linked to task tracker where applicable

[OmarIthawi]

The name of the file is pull_request.yml but it runs on push.

I recommend using the generic sultan-ci.yml file name.

Suggested change

	on: push
	on: push

[iamjazzar]

I originally intended to run on pull requests, I totally forget about changing this.

[OmarIthawi]

If you case you've forgot to run it on pull_request. The syntax below means that the ci will run on every pull request, in addition to push on the juniper branch.

This means that a PR merge, will trigger another build that allows us to actually save the image instead of just testing the pipeline.

Suggested change

	on: push
	on:
	pull_request:
	push:
	branches:
	- juniper

[iamjazzar]

Triggering on pull_request won't allow us to fetch the branch name. Push actually works on merge too. Here's a proof:

• The workflow run on devstack repo: https://github.com/appsembler/devstack/runs/3036630625?check_suite_focus=true
• The workflow run on Sultan: https://github.com/appsembler/sultan/runs/3036632015?check_suite_focus=true
• And here's a picture of the created image