Appsembler Travis #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Argh. Why does edX make such gigantic tests for everything? TravisCI fails because: Not helpful. |
Author
|
Ah, actually, it's our good friend the infinite loop in |
OmarIthawi
approved these changes
Feb 19, 2019
OmarIthawi
left a comment
OmarIthawi
left a comment
There was a problem hiding this comment.
LGTM if Travis is OK with it 😉
Thanks @thraxil!
|
@thraxil I was hoping that what I read is a joke, but sadly it turns out to be true: npm/npm#18477 😒 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want to run the TravisCI tests on our changes. I've enabled that through the web UI. This PR just updates the badge in the README to point to ours (and serves to test the build for the first time).