[WIP] release-next #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: get app info * feat: support install dmg * fix: fail to install dmg * feat: support install nvm * feat: support install pkg * fix: install dmg error * chore: update ui * fix: optimize code * feat: add child_process * fix: terminal ui * chore: add todo * fix: ipc * fix: type * fix: install logic * feat: install confirm dialog * fix: ui * fix: lint * fix: add node manager processor * fix: node not found in prod * fix: version status * feat: node manager ui * fix: state * chore: optimization * chore: notInstalled -> uninstalled * fix: version status * chore: optimization * feat: update icon * chore: remove stepItemRender component * fix: logic * fix: format path * chore: comment * chore: add husky * feat: install new UI * chore: version * feat: optimize * feat: husky * chore: optimize * fix: install more than one child_process * feat: support install extension * feat: link code command * feat: install package icon * feat: install result * fix: xterm fontsize * chore: package-lock.json * chore: update package-lock.json * feat: support reinstall npm package * feat: install global npm package step * chore: package-lock.json * fix: renderer package install error * fix: static not found in prod env * fix: internal logic * fix: git isInternal param * fix: typo
Contributor
|
Mac下配置环境变量配置生效问题： |
alvinhui
reviewed
May 26, 2021
| managerPath: null, | ||
| managerVersion: null, | ||
| }; | ||
| const nvmDir = process.env.NVM_DIR; |
Contributor
There was a problem hiding this comment.
这里如果是通过进程内的环境变量来获取，那么如果用户没有 nvm ，然后再通过 toolkit 安装了 nvm，返回到界面还是会显示没有安装 nvm 吧？
因为环境变量里的这个值是不会刷新的？
* fix: node version not update * chore: comment
* feat: auto update * feat: add upload oss script * chore: version * chore: comment
alvinhui
approved these changes
May 31, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature：
Todo:
Ref: #5