Skip to content

Delay expiry alerts if the key is just created #1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025
Merged

Delay expiry alerts if the key is just created #1864

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions ...es/(console)/project-[region]-[project]/overview/(components)/updateExpirationDate.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@
import { Alert } from '@appwrite.io/pink-svelte';
import { ExpirationInput } from '$lib/components';
import type { Models } from '@appwrite.io/console';
import { page } from '$app/stores';
import { page } from '$app/state';

export let keyType: 'api' | 'dev' = 'api';
export let key: Models.DevKey | Models.Key;

const projectId = $page.params.project;
const projectId = page.params.project;

const isApiKey = keyType === 'api';
const label = isApiKey ? 'API' : 'Dev';
Expand Down Expand Up @@ -68,14 +68,17 @@
typeof key?.expire === 'undefined' && expiration === null
? true
: isSameDay(new Date(expiration), new Date(key?.expire));

// don't show an expiry related alert if key was created less than 5 mins ago!
$: showAlert = Date.now() - new Date(key.$createdAt).getTime() > 5 * 60 * 1000;
</script>

<Form onSubmit={updateExpire}>
<CardGrid>
<svelte:fragment slot="title">Expiration date</svelte:fragment>
Set a date after which your {label} key will expire.
<svelte:fragment slot="aside">
{#if isExpired || isExpiring}
{#if (isExpired || isExpiring) && showAlert}
<Alert.Inline
status={isExpired && isApiKey ? 'error' : 'warning'}
on:dismiss={() => (alertsDismissed = true)}
Expand Down
Loading