Fix undefined errors #1878
Merged
Fix undefined errors #1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though upgradeURL isn't used when there are no free orgs, this line is still evaluated and will throw an error because freeOrganization is undefined. This commit adds a null check to prevent this error.
When going from /account to /organization/[organization]/change-plan, the currentPlan and organization variables may not be defined as the states are still being set. This change ensures an error isn't thrown so that the states can update fully.
TorstenDittmann
approved these changes
May 22, 2025
ItzNotABug
approved these changes
May 25, 2025
TorstenDittmann
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Test Plan
Billing
From the /account page and with a Free org, clicked the Support button > Get Premium support button and verified the change plan page loaded successfully.
Support
From the /account page with an account with only a Pro org, clicked the Support button and confirmed the menu appeared:
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)