Skip to content

Fix domain check and max size #1888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 24, 2025
Merged

Fix domain check and max size #1888

merged 3 commits into from
May 24, 2025

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented May 24, 2025 •
edited
Loading

What does this PR do?

  1. Max size was always 10MB:

CleanShot 2025-05-24 at 23 17 52@2x

  1. Domain was always considered valid, but always failed to create rule:

CleanShot 2025-05-24 at 23 22 37@2x

CleanShot 2025-05-24 at 23 26 28@2x

  1. Manual deployment of ~50mb fails to deploy

CleanShot 2025-05-24 at 23 30 22@2x

CleanShot 2025-05-24 at 23 30 25@2x

Test Plan

  1. Max size now respects env var:
    CleanShot 2025-05-24 at 23 25 28@2x

  2. Rule now creates successfully

CleanShot 2025-05-24 at 23 29 49@2x

  1. Manual deployment works no matter size

CleanShot 2025-05-24 at 23 57 56@2x

CleanShot 2025-05-24 at 23 58 15@2x

CleanShot 2025-05-25 at 00 02 25@2x

Related PRs and Issues

https://discord.com/channels/564160730845151244/1375865210279166113

Have you read the Contributing Guidelines on issues?

Yes

This was referenced May 24, 2025
Merged
Merged
@Meldiron Meldiron marked this pull request as ready for review May 24, 2025 22:12
@Meldiron Meldiron merged commit 7224761 into main May 24, 2025
2 checks passed
@Meldiron Meldiron deleted the fix-site-deployment branch May 24, 2025 22:51
@stnguyen90 stnguyen90 moved this to Done in 1.7 Release May 25, 2025
@Meldiron Meldiron mentioned this pull request May 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TorstenDittmann TorstenDittmann TorstenDittmann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

1.7 Release
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Meldiron @TorstenDittmann