Fix undefined errors #1919
Merged
Fix undefined errors #1919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using undefined as the initial value can lead to issues when trying to access the store such as: TypeError: Cannot read properties of undefined (reading 'regions')
The regions store is populated elsewhere already so no need to do it again here. Also, $organization may not be defined on mount which would lead to: TypeError: Cannot read properties of undefined (reading '$id')
stnguyen90
force-pushed
the
fix-undefined-organization-id
branch
from
8b8f958 to
e4c66b1
Compare
ItzNotABug
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
regions.regions.Test Plan
Manually tested going to /console/onboarding/create-project
Before:
After:
Manually browsed from /console/account/organizations to an organization
Before:
After:
Related PRs and Issues
None
Have you read the Contributing Guidelines on issues?
Yes