Refactor breadcrumbs to use page store for selected project #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TorstenDittmann
commented
May 28, 2025
TorstenDittmann
commented
- Replace project selection logic with page.data.project
- Add type annotations for better type safety
- Clean up component formatting and remove unused isSelected property
- Replace project selection logic with page.data.project - Add type annotations for better type safety - Clean up component formatting and remove unused isSelected property
ItzNotABug
requested changes
May 28, 2025
| import { base } from '$app/paths'; | ||
| import { newOrgModal } from '$lib/stores/organization'; | ||
| import { Click, trackEvent } from '$lib/actions/analytics'; | ||
| import { page } from '$app/stores'; |
There was a problem hiding this comment.
why not page from $app/state?
| href={`/console/project-${project.region}-${project.$id}`} | ||
| >{project.name}</ActionMenu.Item.Anchor | ||
| ></ActionMenu.Root> | ||
| href={`/console/project-${project.region}-${project.$id}`}> |
| href={`/console/organization-${selectedOrg.$id}`} | ||
| >All projects</ActionMenu.Item.Anchor | ||
| ></ActionMenu.Root> | ||
| href={`/console/organization-${selectedOrg.$id}`}> |
| href={`/console/organization-${selectedOrg?.$id}?create-project`} | ||
| >Create project</ActionMenu.Item.Anchor | ||
| ></ActionMenu.Root> | ||
| href={`/console/organization-${selectedOrg?.$id}?create-project`}> |
Replace hardcoded `/console` paths with `${base}` prefix and migrate
from `$app/stores` to `$app/state` for page access.
Change import from `$app/state` to `$app/stores` and update usage from `page.data.project` to `$page.data.project` to properly access the reactive store value.
ItzNotABug
approved these changes
May 28, 2025
Adds isSelected boolean to project objects based on current page params and applies NavbarProject type constraint with satisfies operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.