Skip to content

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented May 29, 2025

What does this PR do?

There is a separate Resource limits card down the page that allows user to change the runtime specification so there's no need to have it in the Runtime card.

Test Plan

Manually tested:

image

Related PRs and Issues

None

Have you read the Contributing Guidelines on issues?

Yes

@stnguyen90 stnguyen90 moved this to Code Review in 1.7 Release May 29, 2025
Copy link
Contributor

@ArmanNik ArmanNik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to remove the specs input, since we have a card dedicated that:
image

There is a separate Resource limits card down the page that allows user
to change the runtime specification so there's no need to have it in the
Runtime card.
@stnguyen90 stnguyen90 force-pushed the fix-update-runtime-specification branch from beabf16 to 9eafa40 Compare May 29, 2025 15:43
@stnguyen90 stnguyen90 changed the title fix(functions): update runtime specification handling fix(functions): remove specification from function runtime settings May 29, 2025
@stnguyen90 stnguyen90 requested a review from ArmanNik May 29, 2025 16:00
@ArmanNik ArmanNik merged commit ab4a73b into main May 30, 2025
2 checks passed
@ArmanNik ArmanNik deleted the fix-update-runtime-specification branch May 30, 2025 07:37
@github-project-automation github-project-automation bot moved this from Code Review to Done in 1.7 Release May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants