Skip to content

Conversation

stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented May 30, 2025

What does this PR do?

Because the newOrgId was being used, there were team not found errors and the estimated total box wouldn't show:

image

This PR ensures we don't use the newOrgId

Test Plan

Manually tested to ensure the estimated total showed:

image

Created org:

image

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

Yes

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issues where using newOrgId causes team not found errors and prevents the estimated total from showing.

  • Added a conditional check to exclude newOrgId when fetching the organization plan.
  • Updated the organizationId binding in the component to conditionally pass null when newOrgId is used.
Comments suppressed due to low confidence (1)

src/routes/(console)/apply-credit/+page.svelte:366

  • [nitpick] Consider refactoring the repeated condition into a computed property to improve code readability and reduce potential future errors.
organizationId={selectedOrgId && selectedOrgId !== newOrgId ? selectedOrgId : null}

Copy link
Member

@ItzNotABug ItzNotABug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, rest lgtm.

@stnguyen90 stnguyen90 force-pushed the fix-estimated-total branch from 4654f88 to 763927a Compare June 1, 2025 17:19
@stnguyen90 stnguyen90 requested a review from ItzNotABug June 1, 2025 17:19
@stnguyen90 stnguyen90 merged commit 2ac0920 into main Jun 2, 2025
2 checks passed
@stnguyen90 stnguyen90 deleted the fix-estimated-total branch June 2, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants