Fix creating org w/o coupon #1959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stnguyen90
force-pushed
the
fix-create-pro-org
branch
from
02f5438 to
3c9b920
Compare
stnguyen90
changed the title
stnguyen90
requested review from
ArmanNik,
ItzNotABug,
TorstenDittmann and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an undefined error when creating an organization without a coupon by simplifying the coupon code parameter.
- Changed the coupon code argument from a ternary check to optional chaining.
- Removed redundant
? selectedCoupon.code : nullin favor ofselectedCoupon?.code.
| paymentMethodId, | ||
| null, | ||
| selectedCoupon.code ? selectedCoupon.code : null, | ||
| selectedCoupon?.code, |
There was a problem hiding this comment.
Using selectedCoupon?.code can yield undefined when no coupon is selected, which may not match the API’s expected null value. Consider using selectedCoupon?.code ?? null to explicitly pass null in that case.
Suggested change
| selectedCoupon?.code, | |
| selectedCoupon?.code ?? null, |
Copilot uses AI. Check for mistakes.
ItzNotABug
approved these changes
Jun 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a bug where creating an org w/o a coupon would result in undefined error.
Test Plan
Manual
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes