Comment out onNotFound handler in Row

[TorstenDittmann]

Summary by CodeRabbit

• Refactor
  • Simplified role deletion handling in the permissions interface by consolidating internal deletion logic.

[appwrite]

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)

Site	Status	Logs	Preview	QR
console-stage 688b7cf6003b1842c9dc	Ready	View Logs	Preview URL

Tip

Environment variable changes require redeployment to take effect

[coderabbitai]

Walkthrough

A single prop removal in the permissions.svelte component changes how the Row component is invoked within a role table cell. The onNotFound callback prop was removed, shifting deletion error handling from an explicit per-row callback to alternative handling mechanisms. This is a focused change in one file affecting a single component invocation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

• Row component behavior: Verify how the Row component now handles deletion scenarios without the onNotFound callback and confirm internal behavior or alternative handlers are sufficient.
• Deletion flow: Understand why this callback is no longer required and confirm the permission deletion workflow remains intact.
• Error handling: Check if deletion errors are now handled elsewhere or if this represents intentional removal of specific error handling logic.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the specific change made: removing/commenting out the onNotFound prop handler in the Row component within the permissions template.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-prevent-row-deletion

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e02c4e2 and a56be7a.

📒 Files selected for processing (1)

• src/lib/components/permissions/permissions.svelte (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: e2e
• GitHub Check: build

🔇 Additional comments (1)

src/lib/components/permissions/permissions.svelte (1)

143-143: No changes needed—Row component handles missing onNotFound prop gracefully.

The Row component is designed defensively: the onNotFound prop is optional, and it uses optional chaining (onNotFound?.(role)) to invoke it safely. The component renders correctly whether the prop is passed or not. Role deletion remains fully functional via the delete button and works independently of any Row callback. The Row component also properly handles the notFound state in the UI display, showing appropriate fallback content when data is unavailable.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}