Fix: Preserve null value for "Never" expiration option #2605

Copilot · 2025-11-17T23:06:37Z

Fix: Invalid `expire` param when creating API Key or File Token

This PR fixes the bug where selecting "Never" as the expiration for API Keys or File Tokens results in an invalid expire parameter being sent to the API.

Root Cause

The reactive block in ExpirationInput unconditionally converted all values to ISO date strings:

value = toLocaleDateISO(new Date(value).getTime());

When "Never" was selected (value = null), this converted it to '1970-01-01' (epoch date), which failed API validation.

Solution

Made two changes:

ExpirationInput component: Added null check before ISO date conversion

// Before
value = toLocaleDateISO(new Date(value).getTime());

// After  
if (value !== null) {
    value = toLocaleDateISO(new Date(value).getTime());
}

Preserves null values for "Never" expiration

API key creation component: Changed initialization from empty string to null
```
// Before
let name = '', expire = '';

// After
let name = '';
let expire: string | null = null;
```
- Now matches the approach used in file token component
- Simpler than handling invalid date strings in ExpirationInput

Impact

Fixes expiration handling across all components using ExpirationInput:

✅ API Key creation (now initialized with null)
✅ API Key expiration updates
✅ File Token creation and updates (already used null)
✅ Dev Key management

Additional Changes

Updated AGENTS.md with mandatory pre-completion checklist to ensure all future changes run formatter, tests, and checks before completion

Verification

✅ All 227 tests pass
✅ Prettier formatting passes
✅ Build completes successfully

Fixes #2604

Original prompt

This section details on the original issue you should resolve

<issue_title>Bug: Invalid expire param when creating API Key or File Token</issue_title>
<issue_description>## Summary
When attempting to create an API key or a File token, the following error is returned:

Invalid expire param: Value must be valid date in the future and between 0000-01-01 00:00:00 and 9999-12-31 00:00:00. or null

Steps to Reproduce

Go to the section to create an API key or File token in the console

Set the expire parameter to Never

Attempt to create the API key or File token

Observe the error message above

Expected Behavior

API key or File token should be created successfully when the provided expire param is a valid future date or is left as null.

Actual Behavior

Creation fails with an error about the expire param being invalid.

Additional Information

The error occurs for both API key and File token creation

Possibly related to input validation logic for the expire field

Suggested Next Steps

Review and fix validation logic for the expire parameter to ensure valid dates and null are accepted

Add additional safeguards or tests for edge cases involving the date range

If more tracing or logs are needed, let me know and I'll help gather them.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Bug: Invalid expire param when creating API Key or File Token #2604

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

appwrite · 2025-11-17T23:06:43Z

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)

Site	Status	Logs	Preview	QR
console-stage `688b7cf6003b1842c9dc`	Ready	View Logs	Preview URL

Tip

Function scopes give you fine-grained control over API permissions

coderabbitai · 2025-11-17T23:06:43Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

- Fixed reactive block in expirationInput.svelte to check for null before converting to ISO date - When "Never" is selected, value now remains null instead of being converted to '1970-01-01' - This allows the API to correctly handle null expiration dates for API keys and file tokens Co-authored-by: stnguyen90 <1477010+stnguyen90@users.noreply.github.com>

stnguyen90

@copilot the file token will generate now, but the API key still won't.

- Updated initialization logic to handle both null and invalid date values (including empty strings) - Removed the check for expirationSelect !== null to allow proper initialization when "Never" is selected - Added isValidDate check before ISO date conversion to prevent converting invalid dates to 'n/a' - This fixes the issue where API keys couldn't be created with "Never" expiration when the parent component initializes expire as an empty string Co-authored-by: stnguyen90 <1477010+stnguyen90@users.noreply.github.com>

Copilot · 2025-11-18T02:56:25Z

@copilot the file token will generate now, but the API key still won't.

Fixed in commit c772abc. The issue was that API key creation initializes expire as an empty string '' rather than null. The initialization logic now handles both invalid values (including empty strings) and properly sets them to null when "Never" is selected. Also added validation before ISO date conversion to prevent invalid dates from being converted to 'n/a'.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

o1.ingest.sentry.io
- Triggering command: node (vitest) (dns block)
- Triggering command: node build.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

stnguyen90

@copilot instead of changing

stnguyen90 · 2025-11-18T04:21:30Z

@copilot Run the formatter because there is a lint error.

Added a "Required Pre-Completion Checklist" section that instructs agents to: - Always run format, check, lint, test, and build before finishing - Fix any failures before marking work complete - Never skip these mandatory quality gates This addresses the requirement to ensure all code changes are properly validated. Co-authored-by: stnguyen90 <1477010+stnguyen90@users.noreply.github.com>

Copilot · 2025-11-18T04:26:18Z

@copilot Run the formatter because there is a lint error.

Done in commit a17bb09. Ran pnpm run format which auto-fixed the formatting issue in .github/workflows/dockerize-profiles.yml. Also updated AGENTS.md with a mandatory pre-completion checklist to ensure all future changes run formatter, tests, and checks before completion.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

o1.ingest.sentry.io
- Triggering command: node (vitest) (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

src/lib/components/expirationInput.svelte

stnguyen90

@copilot please also update this branch with the latest from main to hopefully fix the CI tests

src/lib/components/expirationInput.svelte

…ram-validation

- Changed API key create component to initialize `expire = null` instead of `expire = ''` - Reverted complex invalid date handling in ExpirationInput component - Kept only the essential null value handling in ExpirationInput - This matches the approach used in file token component and is simpler This addresses reviewer feedback to handle the issue at the source (parent component) rather than making the ExpirationInput component more complex. Co-authored-by: stnguyen90 <1477010+stnguyen90@users.noreply.github.com>

Copilot · 2025-11-20T17:50:00Z

@copilot please also update this branch with the latest from main to hopefully fix the CI tests

Done in commit 0d77f88. Branch has been updated with the latest from main.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

o1.ingest.sentry.io
- Triggering command: node (vitest) (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot AI self-assigned this Nov 17, 2025

Initial plan

349d75c

Copilot AI assigned stnguyen90 Nov 17, 2025

Copilot started work on behalf of stnguyen90 November 17, 2025 23:06 View session

Copilot AI changed the title ~~[WIP] Fix invalid expire param error in API key creation~~ Fix: Preserve null value for "Never" expiration option Nov 17, 2025

Copilot AI requested a review from stnguyen90 November 17, 2025 23:21

Copilot finished work on behalf of stnguyen90 November 17, 2025 23:21

stnguyen90 requested changes Nov 18, 2025

View reviewed changes

Copilot started work on behalf of stnguyen90 November 18, 2025 02:49 View session

Copilot AI requested a review from stnguyen90 November 18, 2025 02:58

Copilot finished work on behalf of stnguyen90 November 18, 2025 02:58

stnguyen90 approved these changes Nov 18, 2025

View reviewed changes

stnguyen90 marked this pull request as ready for review November 18, 2025 03:04

stnguyen90 approved these changes Nov 18, 2025

View reviewed changes

Copilot started work on behalf of stnguyen90 November 18, 2025 04:21 View session

Copilot AI requested a review from stnguyen90 November 18, 2025 04:29

Copilot finished work on behalf of stnguyen90 November 18, 2025 04:29

stnguyen90 approved these changes Nov 18, 2025

View reviewed changes

stnguyen90 reviewed Nov 19, 2025

View reviewed changes

src/lib/components/expirationInput.svelte Outdated Show resolved Hide resolved

stnguyen90 requested a review from ItzNotABug November 19, 2025 00:01

stnguyen90 requested changes Nov 20, 2025

View reviewed changes

src/lib/components/expirationInput.svelte Outdated Show resolved Hide resolved

Copilot started work on behalf of stnguyen90 November 20, 2025 17:45 View session

Copilot AI and others added 2 commits November 20, 2025 17:46

Merge remote-tracking branch 'origin/main' into copilot/fix-expire-pa…

b69cc34

…ram-validation

Copilot AI requested a review from stnguyen90 November 20, 2025 17:51

Copilot finished work on behalf of stnguyen90 November 20, 2025 17:51

stnguyen90 approved these changes Nov 21, 2025

View reviewed changes

ItzNotABug approved these changes Nov 21, 2025

View reviewed changes

stnguyen90 merged commit 273488f into main Nov 21, 2025
6 checks passed

stnguyen90 deleted the copilot/fix-expire-param-validation branch November 21, 2025 14:44

Fix: Preserve null value for "Never" expiration option #2605

Fix: Preserve null value for "Never" expiration option #2605

Conversation

Copilot AI commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix: Invalid expire param when creating API Key or File Token

Root Cause

Solution

Impact

Additional Changes

Verification

Steps to Reproduce

Expected Behavior

Actual Behavior

Additional Information

Suggested Next Steps

Comments on the Issue (you are @copilot in this section)

Uh oh!

appwrite bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Console (appwrite/console)

Uh oh!

coderabbitai bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

stnguyen90 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

stnguyen90 left a comment

Choose a reason for hiding this comment

Uh oh!

stnguyen90 commented Nov 18, 2025

Uh oh!

Copilot AI commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

stnguyen90 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 17, 2025 •

edited

Loading

Fix: Invalid `expire` param when creating API Key or File Token

appwrite bot commented Nov 17, 2025 •

edited

Loading

coderabbitai bot commented Nov 17, 2025 •

edited

Loading

Copilot AI commented Nov 18, 2025 •

edited

Loading

Copilot AI commented Nov 18, 2025 •

edited

Loading

Copilot AI commented Nov 20, 2025 •

edited

Loading