Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 19, 2025

The Update button becomes disabled when clearing the tenantID field in Microsoft OAuth settings, preventing users from removing an optional tenant configuration.

Root Cause

The reactive secret statement required both clientSecret and tenantID to be truthy before constructing a new secret. When tenantID is cleared, the condition fails and secret reverts to provider.secret, making the component think nothing changed.

// Before: Both fields required for new secret
$: secret = clientSecret && tenantID 
    ? JSON.stringify({ clientSecret, tenantID }) 
    : provider.secret;

// After: tenantID is optional
$: secret = clientSecret
    ? JSON.stringify({ clientSecret, ...(tenantID && { tenantID }) })
    : provider.secret;

Changes

  • Use spread operator to conditionally include tenantID only when present
  • Clearing tenantID now produces { clientSecret } instead of reverting to original secret
  • Update button correctly detects the change and enables

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • o1.ingest.sentry.io
    • Triggering command: node (vitest) (dns block)
    • Triggering command: node build.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

On microsoftOAuth.svelte, When someone has tenantID set and then they try to delete it, the Update button becomes disabled.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@appwrite
Copy link

appwrite bot commented Nov 19, 2025

Console (appwrite/console)

Project ID: 688b7bf400350cbd60e9

Sites (1)
Site Status Logs Preview QR
 console-stage
688b7cf6003b1842c9dc
Ready Ready View Logs Preview URL QR Code

Tip

Sites support three domain rule types: Active deployment, Git branch, and Redirect

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 19, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Comment @coderabbitai help to get the list of available commands and usage tips.

Co-authored-by: stnguyen90 <1477010+stnguyen90@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix update button disabling when deleting tenant ID Fix Update button disabled when clearing optional tenantID in Microsoft OAuth Nov 19, 2025
Copilot AI requested a review from stnguyen90 November 19, 2025 23:46
Copilot finished work on behalf of stnguyen90 November 19, 2025 23:46
@stnguyen90 stnguyen90 marked this pull request as ready for review November 19, 2025 23:59
@HarshMN2345 HarshMN2345 self-requested a review November 20, 2025 05:09
@stnguyen90 stnguyen90 merged commit 345acee into main Nov 21, 2025
6 checks passed
@stnguyen90 stnguyen90 deleted the copilot/fix-update-button-disable-issue branch November 21, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update button disabled when removing Tenant ID in Microsoft OAuth settings

3 participants