feat-custom-exception-model #113
Conversation
| class {{spec.title | caseUcfirst}}Exception implements Exception { | ||
| final String message; | ||
| final int code; | ||
| final dynamic response; |
There was a problem hiding this comment.
Can we maybe have a specific type here? 🤔
String maybe?
Map<String, dynamic> is fine as well, but as a mobile developer who is coming from strongly typed languages like kotlin, java or swift I like having types 👍
There was a problem hiding this comment.
If the response can be different in some cases it's fine to have dynamic but then I would add a little comment to it. In our case, we are casting to some type.
There was a problem hiding this comment.
I believe the response can be Json or can be String as well. @eldadfux do you agree?
There was a problem hiding this comment.
Yeh It might be tricky because sometimes a proxy can throw the error and we can't be sure of the format.
| } | ||
| } on DioError catch(e) { | ||
| if(e.response == null) { | ||
| throw {{spec.title | caseUcfirst}}AppwriteException(e.message); |
There was a problem hiding this comment.
I think this line in the Exceptions PR is wrong: throw {{spec.title | caseUcfirst}}AppwriteException(e.message); as it resolve to AppwriteAppwriteException
3 participants
No description provided.