Skip to content

Use string interpolation instead of concatenation in Dart/Flutter #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

Use string interpolation instead of concatenation in Dart/Flutter #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion templates/dart/lib/src/client_browser.dart.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class ClientBrowser extends ClientBase with ClientMixin {
try {
res = await call(
HttpMethod.get,
path: path + '/' + params[idParamName],
path: '$path/${params[idParamName]}',
headers: headers,
);
final int chunksUploaded = res.data['chunksUploaded'] as int;
Expand Down
2 changes: 1 addition & 1 deletion templates/dart/lib/src/client_io.dart.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class ClientIO extends ClientBase with ClientMixin {
try {
res = await call(
HttpMethod.get,
path: path + '/' + params[idParamName],
path: '$path/${params[idParamName]}',
headers: headers,
);
final int chunksUploaded = res.data['chunksUploaded'] as int;
Expand Down
4 changes: 2 additions & 2 deletions templates/flutter/lib/src/client_browser.dart.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ class ClientBrowser extends ClientBase with ClientMixin {
try {
res = await call(
HttpMethod.get,
path: path + '/' + params[idParamName],
path: '$path/${params[idParamName]}',
headers: headers,
);
final int chunksUploaded = res.data['chunksUploaded'] as int;
Expand Down Expand Up @@ -243,7 +243,7 @@ class ClientBrowser extends ClientBase with ClientMixin {
Future webAuth(Uri url, {String? callbackUrlScheme}) {
return FlutterWebAuth2.authenticate(
url: url.toString(),
callbackUrlScheme: "{{spec.title | caseLower}}-callback-" + config['project']!,
callbackUrlScheme: "{{spec.title | caseLower}}-callback-${config['project']!}",
options: const FlutterWebAuth2Options(useWebview: false),
);
}
Expand Down
4 changes: 2 additions & 2 deletions templates/flutter/lib/src/client_io.dart.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ class ClientIO extends ClientBase with ClientMixin {
try {
res = await call(
HttpMethod.get,
path: path + '/' + params[idParamName],
path: '$path/${params[idParamName]}',
headers: headers,
);
final int chunksUploaded = res.data['chunksUploaded'] as int;
Expand Down Expand Up @@ -333,7 +333,7 @@ class ClientIO extends ClientBase with ClientMixin {
url: url.toString(),
callbackUrlScheme: callbackUrlScheme != null && _customSchemeAllowed
? callbackUrlScheme
: "{{spec.title | caseLower}}-callback-" + config['project']!,
: "{{spec.title | caseLower}}-callback-${config['project']!}",
options: const FlutterWebAuth2Options(
intentFlags: ephemeralIntentFlags,
useWebview: false,
Expand Down
Loading