chore: ensure the full analysis options are used when formatting #1214
Conversation
Install the dependencies so that the full analysis options are used when formatting.
WalkthroughThe PR makes broad template updates across Dart and Flutter generators: CI format workflows now install dependencies and commit both lib and test; OAuth and query construction use string interpolation for encoded parameters; Query constructor default initializers were removed; generated client header setter parameters were typed as String; minor string/key interpolation and user-agent value fixes; a local variable rename in realtime IO; and realtime mixin changes (subscriptions made final, explicit Future return, and path built via interpolation). Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (10)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
🔇 Additional comments (13)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
templates/flutter/.github/workflows/format.yml.twig (1)
21-27: LGTM! Flutter installation and dependency management properly configured.Removing the Dart container and using
subosito/flutter-action@v2is the correct approach for Flutter projects. The sequence of installing Flutter first, then runningflutter pub getensures dependencies and analysis options are available before formatting.Optional: Consider pinning to a specific version for reproducibility.
While using
v2is common practice, pinning to a specific version (e.g.,v2.16.0) could improve reproducibility by preventing unexpected updates.- name: Install Flutter - uses: subosito/flutter-action@v2 + uses: subosito/flutter-action@v2.16.0 with: channel: stable
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
templates/dart/.github/workflows/format.yml.twig(2 hunks)templates/flutter/.github/workflows/format.yml.twig(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (18)
- GitHub Check: build (8.3, AppleSwift56)
- GitHub Check: build (8.3, Ruby30)
- GitHub Check: build (8.3, Python313)
- GitHub Check: build (8.3, Python312)
- GitHub Check: build (8.3, PHP80)
- GitHub Check: build (8.3, KotlinJava11)
- GitHub Check: build (8.3, Node16)
- GitHub Check: build (8.3, KotlinJava17)
- GitHub Check: build (8.3, FlutterStable)
- GitHub Check: build (8.3, FlutterBeta)
- GitHub Check: build (8.3, DotNet90)
- GitHub Check: build (8.3, DartBeta)
- GitHub Check: build (8.3, Android5Java17)
- GitHub Check: build (8.3, Android14Java17)
- GitHub Check: android (client)
- GitHub Check: swift (server)
- GitHub Check: flutter (client)
- GitHub Check: apple (client)
🔇 Additional comments (3)
templates/dart/.github/workflows/format.yml.twig (2)
23-24: LGTM! Dependencies now installed before formatting.Running
dart pub getensures the analysis options and dependencies are properly set up before formatting, which aligns with the PR objective to use full analysis options.
35-35: LGTM! Test directory now included in commits.Including the test directory ensures that any formatting changes to test files are committed alongside lib directory changes.
templates/flutter/.github/workflows/format.yml.twig (1)
38-38: LGTM! Test directory now included in commits.Including the test directory ensures that any formatting changes to test files are committed alongside lib directory changes, maintaining consistency with the Dart workflow.
2 participants
What does this PR do?
Install the dependencies so that the full analysis options are used when formatting.
Test Plan
Generated the SDK and tested it locally.
Note
The score is not 100% because the SDK I generated was missing the
CHANGELOG.mdFlutter
Dart
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Summary by CodeRabbit