Skip to content

Add error and close callbacks to Swift Realtime service #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 21, 2025
Merged

Add error and close callbacks to Swift Realtime service #1224

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac43a8b
Add error and close callbacks to Swift Realtime service
ChiragAgg5k Oct 21, 2025
cc46d55
Update templates/swift/Sources/Services/Realtime.swift.twig
ChiragAgg5k Oct 21, 2025
c88c9a9
Update templates/swift/Sources/Services/Realtime.swift.twig
ChiragAgg5k Oct 21, 2025
e278eb2
fix: invocation
ChiragAgg5k Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions templates/swift/Sources/Services/Realtime.swift.twig
View file
Open in desktop
Copy link
Member

@loks0n loks0n Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a e2e test for it? Is it easy?

Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,17 @@ open class Realtime : Service {
private var reconnectAttempts = 0
private var subscriptionsCounter = 0
private var reconnect = true

private var onErrorCallbacks: [((Swift.Error?, HTTPResponseStatus?) -> Void)] = []
private var onCloseCallbacks: [(() -> Void)] = []

public func onError(_ callback: @escaping (Swift.Error?, HTTPResponseStatus?) -> Void) {
self.onErrorCallbacks.append(callback)
}

public func onClose(_ callback: @escaping () -> Void) {
self.onCloseCallbacks.append(callback)
}

private func startHeartbeat() {
stopHeartbeat()
Expand Down Expand Up @@ -212,6 +223,7 @@ extension Realtime: WebSocketClientDelegate {
stopHeartbeat()

if (!reconnect) {
onCloseCallbacks.forEach { $0() }
reconnect = true
return
}
Expand All @@ -230,6 +242,8 @@ extension Realtime: WebSocketClientDelegate {
public func onError(error: Swift.Error?, status: HTTPResponseStatus?) {
stopHeartbeat()
print(error?.localizedDescription ?? "Unknown error")

onErrorCallbacks.forEach { $0(error, status) }
}

func handleResponseError(from json: [String: Any]) throws {
Expand Down
Loading