Skip to content

fix: example generation for php for enums #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

fix: example generation for php for enums #1251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions templates/php/docs/example.md.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,17 @@ use {{ spec.title | caseUcfirst }}\InputFile;
use {{ spec.title | caseUcfirst }}\Services\{{ service.name | caseUcfirst }};
{% set added = [] %}
{% for parameter in method.parameters.all %}
{% if method == parameter.required %}
{% if parameter.enumValues is not empty %}
{% if parameter.enumName is not empty %}
{% set name = parameter.enumName %}
{% else %}
{% set name = parameter.name %}
{% endif %}
{% if name not in added %}
use {{ spec.title | caseUcfirst }}\Enums\{{parameter.enumName | caseUcfirst}};
use {{ spec.title | caseUcfirst }}\Enums\{{ name | caseUcfirst }};
{% set added = added|merge([name]) %}
{% endif %}
{% endif %}
{% endif %}
{% endfor %}
Comment on lines 8 to 21
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Case-sensitivity mismatch in deduplication logic.

The deduplication check at line 16 uses the raw name, but the import statement at line 17 uses name | caseUcfirst. If two parameters have names that differ only in case (e.g., "status" and "Status"), both would pass the deduplication check but generate identical import statements.

Apply this diff to normalize the tracking:

 {% set added = [] %}
 {% for parameter in method.parameters.all %}
 {% if parameter.enumValues is not empty %}
 {% if parameter.enumName is not empty %}
 {% set name = parameter.enumName %}
 {% else %}
 {% set name = parameter.name %}
 {% endif %}
+{% set normalizedName = name | caseUcfirst %}
-{% if name not in added %}
+{% if normalizedName not in added %}
 use {{ spec.title | caseUcfirst }}\Enums\{{ name | caseUcfirst }};
-{% set added = added|merge([name]) %}
+{% set added = added|merge([normalizedName]) %}
 {% endif %}
 {% endif %}
 {% endfor %}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{% set added = [] %}
{% for parameter in method.parameters.all %}
{% if method == parameter.required %}
{% if parameter.enumValues is not empty %}
{% if parameter.enumName is not empty %}
{% set name = parameter.enumName %}
{% else %}
{% set name = parameter.name %}
{% endif %}
{% if name not in added %}
use {{ spec.title | caseUcfirst }}\Enums\{{parameter.enumName | caseUcfirst}};
use {{ spec.title | caseUcfirst }}\Enums\{{ name | caseUcfirst }};
{% set added = added|merge([name]) %}
{% endif %}
{% endif %}
{% endif %}
{% endfor %}
{% set added = [] %}
{% for parameter in method.parameters.all %}
{% if parameter.enumValues is not empty %}
{% if parameter.enumName is not empty %}
{% set name = parameter.enumName %}
{% else %}
{% set name = parameter.name %}
{% endif %}
{% set normalizedName = name | caseUcfirst %}
{% if normalizedName not in added %}
use {{ spec.title | caseUcfirst }}\Enums\{{ name | caseUcfirst }};
{% set added = added|merge([normalizedName]) %}
{% endif %}
{% endif %}
{% endfor %}
🤖 Prompt for AI Agents 
In templates/php/docs/example.md.twig around lines 8 to 21, the deduplication
uses the raw parameter name but the import uses name | caseUcfirst, causing
collisions when names differ only by case; compute a single
normalized/transformed variable (e.g., set importName = name | caseUcfirst) and
use importName for both the use statement and the deduplication check/merge
(added|merge([importName])) so the tracking matches the actual import string.

{% if method.parameters.all | hasPermissionParam %}
use {{ spec.title | caseUcfirst }}\Permission;
Expand All @@ -41,7 +39,7 @@ ${{ service.name | caseCamel }} = new {{ service.name | caseUcfirst }}($client);
$result = ${{ service.name | caseCamel }}->{{ method.name | caseCamel }}({% if method.parameters.all | length == 0 %});{% endif %}

{%~ for parameter in method.parameters.all %}
{{ parameter.name | caseCamel }}: {% if parameter.enumValues | length > 0%}{{ parameter.enumName }}::{{ (parameter.enumKeys[0] ?? parameter.enumValues[0]) | caseEnumKey }}(){% else%}{{ parameter | paramExample }}{% endif %}{% if not loop.last %},{% endif %}{% if not parameter.required %} // optional{% endif %}
{{ parameter.name | caseCamel }}: {% if parameter.enumValues | length > 0%}{% if parameter.enumName is not empty %}{{ parameter.enumName | caseUcfirst }}{% else %}{{ parameter.name | caseUcfirst }}{% endif %}::{{ (parameter.enumKeys[0] ?? parameter.enumValues[0]) | caseEnumKey }}(){% else%}{{ parameter | paramExample }}{% endif %}{% if not loop.last %},{% endif %}{% if not parameter.required %} // optional{% endif %}

{%~ endfor -%}
{% if method.parameters.all | length > 0 %});{% endif %}
Loading