Feat apple + swift SDK support #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sure from pubic methods
Member
lohanidamodar
left a comment
lohanidamodar
left a comment
There was a problem hiding this comment.
Looks almost good to me. Left few comments.
.gitignore
Outdated
|
|
||
| # exception to the rule | ||
| !examples/.gitkeep | ||
| .DS_Store |
Member
There was a problem hiding this comment.
Suggested change
| .DS_Store | |
| **/.DS_Store |
Seems some .DS_Store files are committed to git
|
|
||
| namespace Appwrite\SDK\Language; | ||
|
|
||
| class SwiftClient extends Swift { |
Member
There was a problem hiding this comment.
May be later we should rename this to Apple instead as we do with Kotlin and Android. Swift later might have Clients other than Apple 🤔 ?
tests/SDKTest.php
Outdated
| 'cp tests/languages/swift-server/Tests.swift tests/sdks/swift-server/Tests/AppwriteTests/Tests.swift', | ||
| ], | ||
| 'envs' => [ | ||
| 'swift-5.5' => 'docker run --rm -v $(pwd):/app -w /app/tests/sdks/swift-server swift:5.5 swift test && cat result.txt && rm result.txt', |
Member
There was a problem hiding this comment.
Can we add test for may be the oldest still in use version of Swift we support?
tests/SDKTest.php
Outdated
| 'cp tests/languages/swift-client/Tests.swift tests/sdks/swift-client/Tests/AppwriteTests/Tests.swift', | ||
| ], | ||
| 'envs' => [ | ||
| 'swift-5.5' => 'docker run --rm -v $(pwd):/app -w /app/tests/sdks/swift-client swift:5.5 swift test && cat result.txt && rm result.txt', |
Member
There was a problem hiding this comment.
Can we add test for may be the oldest still in use version of Swift we support?
abnegate
force-pushed
the
feat-swift-templates
branch
from
abe6e2c to
833c91d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.