Skip to content

Conversation

TorstenDittmann
Copy link
Contributor

@TorstenDittmann TorstenDittmann commented Dec 14, 2021

This PR add's the following:

  • properly typed arguments
  • filters in PHP to reduce template clutter
  • split up the Web SDK in Services to allow tree-shaking & co

Output => https://github.com/appwrite/sdk-for-web/tree/feat-service-refactor

@TorstenDittmann TorstenDittmann changed the title fix(web): partial arguments fix(web): typed arguments Dec 14, 2021
@TorstenDittmann TorstenDittmann changed the base branch from master to feat-db-refactor December 14, 2021 17:52
Base automatically changed from feat-db-refactor to master January 4, 2022 09:24
@lohanidamodar
Copy link
Member

@TorstenDittmann will this be ready for 0.13? Otherwise we have some build issues with Console SDK? Might have similar issue in Server and client, haven't tested building yet?

@TorstenDittmann
Copy link
Contributor Author

This only affects server side of Web SDK and so on the console. So this would only affect the Console SDK.

Let me bring the PR up2date during this week so we have no more manual fixing on that 👍🏻

@TorstenDittmann TorstenDittmann marked this pull request as ready for review March 9, 2022 11:21
@TorstenDittmann TorstenDittmann changed the title fix(web): typed arguments fix(web): typed arguments and service classes Jun 1, 2022
@TorstenDittmann TorstenDittmann requested a review from abnegate June 1, 2022 09:24
Copy link
Member

@abnegate abnegate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌

@TorstenDittmann TorstenDittmann merged commit 07f82e7 into master Jun 14, 2022
@TorstenDittmann TorstenDittmann deleted the feat-partial-argument-fixes branch June 14, 2022 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants