-
Notifications
You must be signed in to change notification settings - Fork 189
Implemented deno chunk upload #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few concerns, not sure why kotlin change are here?
@Meldiron please revert the change in the kotlin files and I can merge this PR 🙏🏻 |
|
||
// 16kB chunks block limit: https://github.com/denoland/deno/discussions/9906 | ||
for (let blockIndex = 0; blockIndex < 320; blockIndex++) { | ||
const buf = new Uint8Array(16384); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets make 16384
a const with the comment regarding the reference to why it is used 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stored the value in a const variable on Client, and started using it across the chunking system
@Meldiron Please check and undo the kotlin changes that are still there, I believe the reverted changes are now shown as change after you synced with 0.13 branch. Check and revert accordingly 🙏🏻 |
Snippet:
Output:


