Skip to content

Resumable upload - Dart #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 23, 2022
Merged

Resumable upload - Dart #365

merged 17 commits into from
Feb 23, 2022

Conversation

lohanidamodar
Copy link
Member

@lohanidamodar lohanidamodar commented Feb 13, 2022 •
edited
Loading

  • Adds resumable upload support to chunked files
    • When fileId is provided during createFile, checks if the file already exists
    • if the file already exists, sets the offset based on the chunks already uploaded
    • resumes upload from the remaining chunk

@lohanidamodar lohanidamodar mentioned this pull request Feb 13, 2022
Merged
@lohanidamodar lohanidamodar marked this pull request as ready for review February 15, 2022 02:23
Meldiron
Meldiron reviewed Feb 15, 2022
View reviewed changes
templates/dart/lib/src/chunked_upload_io.dart.twig
Comment on lines +71 to +72
chunksTotal: res.data['chunksTotal'] ?? 0,
chunksUploaded: res.data['chunksUploaded'] ?? 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can it occur we dont get these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In test/mock endpoint

Meldiron
Meldiron approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lohanidamodar lohanidamodar merged commit 0d13b2c into feat-preps-for-0.13 Feb 23, 2022
@lohanidamodar lohanidamodar deleted the feat-resumable-upload-support branch February 23, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Meldiron Meldiron Meldiron approved these changes

+1 more reviewer

@wess wess wess approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lohanidamodar @wess @Meldiron