Skip to content

Conversation

@ChiragAgg5k
Copy link
Member

@ChiragAgg5k ChiragAgg5k commented May 6, 2025

What does this PR do?

  1. removes reconnecting logic
  2. add watchWorkDir to watch file changes done by terminal, returns a filetree view instead of just a layer of fileitems[]
  3. use ws.ping instead of using direct messages

Test Plan

add relevant tests.

Related PRs and Issues

Have you read the Contributing Guidelines on issues?

yes.

@ChiragAgg5k ChiragAgg5k changed the title fix: too many reconnects fix: too many reconnects + filesystem watchFolder May 7, 2025
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing some context, but from a glance lgtm 👍🏻

@TorstenDittmann TorstenDittmann merged commit 9f7c0c7 into main May 7, 2025
1 check passed
@TorstenDittmann TorstenDittmann deleted the fix-disconnects branch May 7, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants