[Orderbook] Allow order validation API to return failure reason and o…

[sitalkedia]

…rder actions

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

• New feature
• Bug fix
• Breaking change
• Performance improvement
• Refactoring
• Dependency update
• Documentation update
• Tests

Which Components or Systems Does This Change Impact?

• Validator Node
• Full Node (API, Indexer, etc.)
• Move/Aptos Virtual Machine
• Aptos Framework
• Aptos CLI/SDK
• Developer Infrastructure
• Move Compiler
• Other (specify)

Checklist

• I have read and followed the CONTRIBUTING doc
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I identified and added all stakeholders and component owners affected by this change as reviewers
• I tested both happy and unhappy path of the functionality
• I have made corresponding changes to the documentation

[github-actions]

✅ Forge suite compat success on e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9 ==> 320afd24b709b5285d339b09ff6a2c4b13c329db

Compatibility test results for e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9 ==> 320afd24b709b5285d339b09ff6a2c4b13c329db (PR)
1. Check liveness of validators at old version: e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9
compatibility::simple-validator-upgrade::liveness-check : committed: 14364.77 txn/s, latency: 2406.81 ms, (p50: 2500 ms, p70: 2700, p90: 2700 ms, p99: 3300 ms), latency samples: 475460
2. Upgrading first Validator to new version: 320afd24b709b5285d339b09ff6a2c4b13c329db
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 5288.88 txn/s, latency: 6520.45 ms, (p50: 7200 ms, p70: 7300, p90: 7400 ms, p99: 7400 ms), latency samples: 182180
3. Upgrading rest of first batch to new version: 320afd24b709b5285d339b09ff6a2c4b13c329db
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 5195.68 txn/s, latency: 6643.51 ms, (p50: 7400 ms, p70: 7500, p90: 7500 ms, p99: 7600 ms), latency samples: 179960
4. upgrading second batch to new version: 320afd24b709b5285d339b09ff6a2c4b13c329db
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 8446.53 txn/s, latency: 4022.31 ms, (p50: 4400 ms, p70: 4500, p90: 4600 ms, p99: 4900 ms), latency samples: 279580
5. check swarm health
Compatibility test for e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9 ==> 320afd24b709b5285d339b09ff6a2c4b13c329db passed
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite realistic_env_max_load success on 320afd24b709b5285d339b09ff6a2c4b13c329db

Forge report malformed: Expecting property name enclosed in double quotes: line 15 column 1 (char 322)
'{\n  "metrics": [\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "submitted_txn",\n      "value": 5398340.0\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "expired_txn",\n      "value": 0.0\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n[2025-10-09T00:49:03Z INFO  aptos_forge::report] Test Ok\n      "metric": "avg_tps",\n      "value": 14197.831998509455\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "avg_latency",\n      "value": 2656.1692753698358\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "p50_latency",\n      "value": 2400.0\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "p90_latency",\n      "value": 3000.0\n    },\n    {\n      "test_name": "two traffics test: inner traffic",\n      "metric": "p99_latency",\n      "value": 6800.0\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "submitted_txn",\n      "value": 43500.0\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "expired_txn",\n      "value": 0.0\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "avg_tps",\n      "value": 99.99439053697725\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "avg_latency",\n      "value": 1199.6436046511628\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "p50_latency",\n      "value": 1000.0\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "p90_latency",\n      "value": 1600.0\n    },\n    {\n      "test_name": "two traffics test",\n      "metric": "p99_latency",\n      "value": 3900.0\n    }\n  ],\n  "text": "two traffics test: inner traffic : committed: 14197.83 txn/s, latency: 2656.17 ms, (p50: 2400 ms, p70: 2600, p90: 3000 ms, p99: 6800 ms), latency samples: 5398340\\ntwo traffics test : committed: 99.99 txn/s, latency: 1199.64 ms, (p50: 1000 ms, p70: 1400, p90: 1600 ms, p99: 3900 ms), latency samples: 1720\\nLatency breakdown for phase 0: [\\"MempoolToBlockCreation: max: 2.384, avg: 1.708\\", \\"ConsensusProposalToOrdered: max: 0.169, avg: 0.164\\", \\"ConsensusOrderedToCommit: max: 0.415, avg: 0.269\\", \\"ConsensusProposalToCommit: max: 0.580, avg: 0.434\\"]\\nMax non-epoch-change gap was: 2 rounds at version 2106444 (avg 0.00) [limit 4], 2.19s no progress at version 2106444 (avg 0.07s) [limit 15].\\nMax epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.24s no progress at version 2116965 (avg 0.24s) [limit 16].\\nTest Ok"\n}'
Trailing Log Lines:
networkchaos.chaos-mesh.org "4-gcp--as-southeast1-to-3-gcp--us-east4-netem" deleted
test CompositeNetworkTest ... ok
Test Statistics: 
two traffics test: inner traffic : committed: 14197.83 txn/s, latency: 2656.17 ms, (p50: 2400 ms, p70: 2600, p90: 3000 ms, p99: 6800 ms), latency samples: 5398340
two traffics test : committed: 99.99 txn/s, latency: 1199.64 ms, (p50: 1000 ms, p70: 1400, p90: 1600 ms, p99: 3900 ms), latency samples: 1720
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.384, avg: 1.708", "ConsensusProposalToOrdered: max: 0.169, avg: 0.164", "ConsensusOrderedToCommit: max: 0.415, avg: 0.269", "ConsensusProposalToCommit: max: 0.580, avg: 0.434"]
Max non-epoch-change gap was: 2 rounds at version 2106444 (avg 0.00) [limit 4], 2.19s no progress at version 2106444 (avg 0.07s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.24s no progress at version 2116965 (avg 0.24s) [limit 16].
Test Ok

=== BEGIN JUNIT ===
<?xml version="1.0" encoding="UTF-8"?>
<testsuites name="forge" tests="1" failures="0" errors="0" uuid="5896c070-89b6-4ca1-bdd9-094af3bd50e3">
    <testsuite name="local" tests="1" disabled="0" errors="0" failures="0">
        <testcase name="CompositeNetworkTest(network:multi-region-network-emulation(two traffics test)) with ">
        </testcase>
    </testsuite>
</testsuites>
=== END JUNIT ===
[2025-10-09T00:49:03Z INFO  aptos_forge::backend::k8s::cluster_helper] Deleting namespace forge-e2e-pr-17811: Some(NamespaceStatus { conditions: None, phase: Some("Terminating") })
[2025-10-09T00:49:03Z INFO  aptos_forge::backend::k8s::cluster_helper] aptos-node resources for Forge removed in namespace: forge-e2e-pr-17811

test result: ok. 1 passed; 0 soft failed; 0 hard failed; 0 filtered out

Debugging output:
NAME                                         READY   STATUS      RESTARTS   AGE
aptos-node-0-fullnode-eforgeab65478c-0       1/1     Running     0          12m
aptos-node-0-validator-0                     1/1     Running     0          12m
aptos-node-1-fullnode-eforgeab65478c-0       1/1     Running     0          12m
aptos-node-1-validator-0                     1/1     Running     0          12m
aptos-node-2-fullnode-eforgeab65478c-0       1/1     Running     0          12m
aptos-node-2-validator-0                     1/1     Running     0          12m
aptos-node-3-fullnode-eforgeab65478c-0       1/1     Running     0          12m
aptos-node-3-validator-0                     1/1     Running     0          12m
aptos-node-4-fullnode-eforgeab65478c-0       1/1     Running     0          12m
aptos-node-4-validator-0                     1/1     Running     0          12m
aptos-node-5-validator-0                     1/1     Running     0          12m
aptos-node-6-validator-0                     1/1     Running     0          12m
forge-testnet-deployer-8nq5l                 0/1     Completed   0          12m
genesis-aptos-genesis-eforgeab65478c-p9mwx   0/1     Completed   0          12m

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking

[github-actions]

✅ Forge suite framework_upgrade success on e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9 ==> 1dd3e3be0498ba8c9e6d23486106328e0be8ff07

Compatibility test results for e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9 ==> 1dd3e3be0498ba8c9e6d23486106328e0be8ff07 (PR)
Upgrade the nodes to version: 1dd3e3be0498ba8c9e6d23486106328e0be8ff07
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2061.94 txn/s, submitted: 2067.95 txn/s, failed submission: 6.01 txn/s, expired: 6.01 txn/s, latency: 1433.63 ms, (p50: 1500 ms, p70: 1500, p90: 1800 ms, p99: 2400 ms), latency samples: 185120
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2170.50 txn/s, submitted: 2176.45 txn/s, failed submission: 5.95 txn/s, expired: 5.95 txn/s, latency: 1354.85 ms, (p50: 1200 ms, p70: 1500, p90: 1800 ms, p99: 2700 ms), latency samples: 197041
5. check swarm health
Compatibility test for e4635b4614ac9cd5e6bcfbfa37fc3d21d28c71b9 ==> 1dd3e3be0498ba8c9e6d23486106328e0be8ff07 passed
Upgrade the remaining nodes to version: 1dd3e3be0498ba8c9e6d23486106328e0be8ff07
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 2250.20 txn/s, submitted: 2257.04 txn/s, failed submission: 6.84 txn/s, expired: 6.84 txn/s, latency: 1315.08 ms, (p50: 1200 ms, p70: 1500, p90: 1500 ms, p99: 1800 ms), latency samples: 203961
Test Ok

• Grafana dashboard
• Humio Logs
• Axiom Logs
• Validator CPU Profile
• Fullnode CPU Profile
• Test runner output
• Test run is land-blocking