test with different jackson versions

Author: rashtao

.github/workflows/maven.yml

@@ -129,3 +129,46 @@ jobs:
         run: mvn -version
       - name: Test
         run: mvn --no-transfer-progress test -DargLine="-Duser.language=${{matrix.user-language}}"
+
+  jackson-test:
+    timeout-minutes: 20
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        jackson-version:
+          - 2.13.3
+          - 2.12.7
+          - 2.11.4
+          - 2.10.5
+        docker-img:
+          - docker.io/arangodb/arangodb:3.9.1
+        topology:
+          - single
+        db-ext-names:
+          - false
+        java-version:
+          - 17
+        user-language:
+          - en
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up JDK
+        uses: actions/setup-java@v2
+        with:
+          java-version: ${{matrix.java-version}}
+          distribution: 'adopt'
+          cache: maven
+      - name: Start Database
+        run: ./docker/start_db.sh
+        env:
+          ARANGO_LICENSE_KEY: ${{ secrets.ARANGO_LICENSE_KEY }}
+          STARTER_MODE: ${{matrix.topology}}
+          DOCKER_IMAGE: ${{matrix.docker-img}}
+          DATABASE_EXTENDED_NAMES: ${{matrix.db-ext-names}}
+      - name: Info
+        run: mvn -version
+      - name: Test
+        run: mvn --no-transfer-progress test -Djackson.version=${{jackson-version}}

pom.xml

@@ -23,6 +23,7 @@
 
     <properties>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+        <jackson.version>2.13.3</jackson.version>
     </properties>
 
     <developers>
@@ -242,6 +243,18 @@
             <groupId>org.apache.httpcomponents</groupId>
             <artifactId>httpclient</artifactId>
         </dependency>
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-databind</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-core</artifactId>
+        </dependency>
+        <dependency>
+            <groupId>com.fasterxml.jackson.core</groupId>
+            <artifactId>jackson-annotations</artifactId>
+        </dependency>
         <dependency>
             <groupId>com.arangodb</groupId>
             <artifactId>jackson-dataformat-velocypack</artifactId>
@@ -289,6 +302,13 @@
 
     <dependencyManagement>
         <dependencies>
+            <dependency>
+                <groupId>com.fasterxml.jackson</groupId>
+                <artifactId>jackson-bom</artifactId>
+                <version>${jackson.version}</version>
+                <scope>import</scope>
+                <type>pom</type>
+            </dependency>
             <dependency>
                 <groupId>com.arangodb</groupId>
                 <artifactId>jackson-dataformat-velocypack</artifactId>

src/main/java/com/arangodb/serde/InternalDeserializers.java

@@ -11,11 +11,10 @@
 import com.fasterxml.jackson.core.JsonGenerator;
 import com.fasterxml.jackson.core.JsonParser;
 import com.fasterxml.jackson.core.TreeNode;
-import com.fasterxml.jackson.databind.*;
-import com.fasterxml.jackson.databind.node.ArrayNode;
-import com.fasterxml.jackson.databind.node.NumericNode;
-import com.fasterxml.jackson.databind.node.ObjectNode;
-import com.fasterxml.jackson.databind.node.TextNode;
+import com.fasterxml.jackson.databind.DeserializationContext;
+import com.fasterxml.jackson.databind.JsonDeserializer;
+import com.fasterxml.jackson.databind.JsonNode;
+import com.fasterxml.jackson.databind.node.*;
 
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
@@ -26,6 +25,13 @@
 
 public final class InternalDeserializers {
 
+    private static <T> T readTreeAsValue(JsonParser p, DeserializationContext ctxt, JsonNode n, Class<T> targetType) throws IOException {
+        try (TreeTraversingParser t = new TreeTraversingParser(n, p.getCodec())) {
+            t.nextToken();
+            return ctxt.readValue(t, targetType);
+        }
+    }
+
     public static class CollectionLinksDeserializer extends JsonDeserializer<Collection<CollectionLink>> {
 
         @Override
@@ -37,7 +43,7 @@ public Collection<CollectionLink> deserialize(JsonParser p, DeserializationConte
                 Map.Entry<String, JsonNode> e = it.next();
                 ObjectNode v = (ObjectNode) e.getValue();
                 v.put("name", e.getKey());
-                out.add(ctxt.readTreeAsValue(v, CollectionLink.class));
+                out.add(readTreeAsValue(p, ctxt, v, CollectionLink.class));
             }
             return out;
         }
@@ -54,7 +60,7 @@ public FieldLink[] deserialize(JsonParser p, DeserializationContext ctxt) throws
                 Map.Entry<String, JsonNode> e = it.next();
                 ObjectNode v = (ObjectNode) e.getValue();
                 v.put("name", e.getKey());
-                out.add(ctxt.readTreeAsValue(v, FieldLink.class));
+                out.add(readTreeAsValue(p, ctxt, v, FieldLink.class));
             }
             return out.toArray(new FieldLink[0]);
         }
@@ -126,7 +132,7 @@ public Response deserialize(final JsonParser p, final DeserializationContext ctx
             response.setType(it.next().intValue());
             response.setResponseCode(it.next().intValue());
             if (it.hasNext()) {
-                response.setMeta(ctxt.readTreeAsValue(it.next(), Map.class));
+                response.setMeta(readTreeAsValue(p, ctxt, it.next(), Map.class));
             }
             return response;
         }

src/main/java/com/arangodb/serde/InternalSerdeImpl.java

@@ -17,6 +17,10 @@ final class InternalSerdeImpl extends JacksonSerdeImpl implements InternalSerde
 
     private final ArangoSerde userSerde;
 
+    static {
+        SerdeUtils.INSTANCE.checkSupportedJacksonVersion();
+    }
+
     InternalSerdeImpl(final ObjectMapper mapper, final ArangoSerde userSerde) {
         super(mapper);
         this.userSerde = userSerde;

src/main/java/com/arangodb/serde/SerdeUtils.java

@@ -1,6 +1,7 @@
 package com.arangodb.serde;
 
 import com.arangodb.ArangoDBException;
+import com.arangodb.jackson.dataformat.velocypack.VPackMapper;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.JavaType;
 import com.fasterxml.jackson.databind.JsonNode;
@@ -9,8 +10,11 @@
 
 import java.lang.reflect.Type;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.List;
 import java.util.Map;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 public enum SerdeUtils {
     INSTANCE;
@@ -68,4 +72,18 @@ public Type convertToType(final JavaType javaType) {
         return constructParametricType(javaType.getRawClass(), args.toArray(new Type[0]));
     }
 
+    void checkSupportedJacksonVersion() {
+        Arrays.asList(
+                com.fasterxml.jackson.databind.cfg.PackageVersion.VERSION,
+                com.fasterxml.jackson.core.json.PackageVersion.VERSION
+        ).forEach(version -> {
+            int major = version.getMajorVersion();
+            int minor = version.getMinorVersion();
+            if (major != 2 || minor < 10 || minor > 13) {
+                Logger.getLogger(VPackMapper.class.getName())
+                        .log(Level.WARNING, "Unsupported Jackson version: {0}", version);
+            }
+        });
+    }
+
 }

src/test/java/com/arangodb/ArangoCollectionTest.java

@@ -41,7 +41,6 @@
 import com.arangodb.util.RawBytes;
 import com.arangodb.util.RawJson;
 import com.fasterxml.jackson.annotation.JsonInclude;
-import com.fasterxml.jackson.annotation.JsonIncludeProperties;
 import com.fasterxml.jackson.core.JsonProcessingException;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import org.junit.jupiter.api.BeforeAll;