don't let libc abort it #21766
Merged
don't let libc abort it #21766
+18
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goedderz
approved these changes
May 15, 2025
lib/Basics/PhysicalMemory.cpp
Outdated
Comment on lines
98
to
100
| std::cerr | ||
| << "failed to parse ARANGODB_OVERRIDE_DETECTED_TOTAL_MEMORY: " | ||
| << value << std::endl; |
Member
There was a problem hiding this comment.
We can't use the logger here, that's a problem that should be solved. But not in this PR. Would you be so kind to open a BTS ticket, so we can address this later?
Contributor
Author
There was a problem hiding this comment.
Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
Co-authored-by: Tobias Gödderz <tobias@arangodb.com>
goedderz
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
in case we fail to parse the environment variable bail out with a meaningfull error message instead of throwing uncaught.