[Feature] GT-40 Add 'crd install' subcommand #1014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikita-vanyasin
changed the title
nikita-vanyasin
changed the title
nikita-vanyasin
force-pushed
the
feature/cmd-ops-crd-install
branch
from
bbd698e to
d7efc22
Compare
jwierzbo
approved these changes
Jun 15, 2022
ajanikow
requested changes
Jun 22, 2022
cmd/cmd.go
Outdated
| "github.com/spf13/cobra" | ||
| flag "github.com/spf13/pflag" | ||
| appsv1 "k8s.io/api/apps/v1" | ||
| v1 "k8s.io/api/core/v1" |
Collaborator
There was a problem hiding this comment.
Please, use import names as they are used everywhere
Contributor
Author
There was a problem hiding this comment.
It was just import auto-ordering, but I corrected them anyway 👌
nikita-vanyasin
force-pushed
the
feature/cmd-ops-crd-install
branch
from
d7efc22 to
f5e9b20
Compare
nikita-vanyasin
force-pushed
the
feature/cmd-ops-crd-install
branch
from
f5e9b20 to
5b380fa
Compare
nikita-vanyasin
changed the title
nikita-vanyasin
force-pushed
the
feature/cmd-ops-crd-install
branch
from
5b380fa to
c146cd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EnsureCRDimplementation was slightly adjusted to return error if requested, so the command can exit with 1 if the problem occurs.