[Bugfix] Add DistributeShardsLike support #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajanikow
commented
Jun 29, 2022
| github.com/arangodb/go-driver v1.2.1 | ||
| github.com/arangodb/go-driver/v2 v2.0.0-20211021031401-d92dcd5a4c83 | ||
| github.com/arangodb/go-upgrade-rules v0.0.0-20180809110947-031b4774ff21 | ||
| github.com/arangodb/rebalancer v0.1.1 |
Collaborator
Author
There was a problem hiding this comment.
Will add Linter rune to check it out
nikita-vanyasin
approved these changes
Jun 29, 2022
informalict
reviewed
Jun 29, 2022
| } | ||
|
|
||
| newPlan, callAgain, err := d.executePlan(ctx, plan, pg) | ||
| newPlan, callAgain, callInLoop, err := d.executePlan(ctx, plan, pg) |
Contributor
There was a problem hiding this comment.
What is the intension of callInLoop if it is always false?
Collaborator
Author
There was a problem hiding this comment.
Please, check latest code - it can be true
ajanikow
force-pushed
the
bugfix/add_distribute_shards_like_support
branch
from
0b4df04 to
6171ecf
Compare
ajanikow
force-pushed
the
bugfix/add_distribute_shards_like_support
branch
from
6171ecf to
b3c37fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.