Skip to content

Conversation

@nikita-vanyasin
Copy link
Contributor

@nikita-vanyasin nikita-vanyasin commented Jun 30, 2022

addlicense command expects license header, not the Go code we provided in make license command.
As a result, it was adding redundant line comment to file header:

// //
// // DISCLAIMER
...

It was adding redundant line comment to license header
@nikita-vanyasin nikita-vanyasin requested a review from ajanikow June 30, 2022 09:06
Copy link
Contributor

@informalict informalict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajanikow ajanikow merged commit fb8d214 into master Jun 30, 2022
@ajanikow ajanikow deleted the build/fix-make-license branch June 30, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants