BREAKING CHANGE: Renamed all enum values to title case #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ewoutp merged 1 commit into master from title-case-enums

Apr 3, 2018

Contributor

ewoutp commented Apr 3, 2018 •

edited

Loading

Changed enum constants to better fit with the way Kubernetes names its enums.

In ArangoDeployment:

mode: cluster -> mode: Cluster
mode: single -> mode: Single
mode: resilientsingle -> mode: ResilientSingle
environment: development -> environment: Development
environment: production -> environment: Production
storageEngine: mmfiles -> storageEngine: MMFiles
storageEngine: rocksdb -> storageEngine: RocksDB
spec.sync.mq.type: direct -> spec.sync.mq.type: Direct


          Renamed all enum values to title case

d5cd274

ewoutp added the 9 Review Required label

kvahed approved these changes

View reviewed changes

Contributor

kvahed left a comment

OK.

ewoutp merged commit 33ef204 into master

ewoutp deleted the title-case-enums branch

April 3, 2018 14:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9 Review Required