Test framework #11
Merged
Test framework #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObiWahn
approved these changes
Feb 26, 2018
Contributor
ObiWahn
left a comment
ObiWahn
left a comment
There was a problem hiding this comment.
LGTM
proposed changes for shell scripts:
https://github.com/arangodb/k8s-operator/tree/test-framework-shell
| @@ -36,30 +38,24 @@ func (d *Deployment) getJWTSecret(apiObject *api.ArangoDeployment) (string, erro | |||
| } | |||
| kubecli := d.deps.KubeCli | |||
| secretName := apiObject.Spec.Authentication.JWTSecretName | |||
| s, err := kubecli.CoreV1().Secrets(apiObject.GetNamespace()).Get(secretName, metav1.GetOptions{}) | |||
Contributor
There was a problem hiding this comment.
Nice that the version gets further abstracted away!
| import ( | ||
| "fmt" | ||
|
|
||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
Contributor
There was a problem hiding this comment.
Do we want meta or metav1 here?
Contributor
Author
There was a problem hiding this comment.
metav1 is used all over the place.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test framework to the project.
The concept is as follows:
make run-testskubectl run ..to run the test docker imageOutput looks like: