Adding syncmaster&worker reconciliation support. #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
matthewvon
previously approved these changes
Jun 4, 2018
|
WAIT ... pushed approved on wrong PR ... just starting on this one. |
matthewvon
dismissed
their stale review
approved wrong PR ... working this one now
matthewvon
reviewed
Jun 4, 2018
| assert.Equal(t, v1.PullNever, def(SyncSpec{ImagePullPolicy: util.NewPullPolicy(v1.PullNever)}).GetImagePullPolicy()) | ||
| assert.Equal(t, "test-jwt", def(SyncSpec{}).Authentication.GetJWTSecretName()) | ||
| assert.Equal(t, "foo", def(SyncSpec{Authentication: SyncAuthenticationSpec{JWTSecretName: util.NewString("foo")}}).Authentication.GetJWTSecretName()) | ||
| } |
There was a problem hiding this comment.
no test for new parameter to monitoring.SetDefaults("string")
Contributor
Author
There was a problem hiding this comment.
Good! Added some tests
matthewvon
approved these changes
Jun 4, 2018
matthewvon
left a comment
matthewvon
left a comment
There was a problem hiding this comment.
Need feedback on unit test failure. but otherwise ok.
Contributor
Author
|
Unit test failures have been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several sync related fixes, tests & improvements.
This PR includes #143