Added unit tests for pv_creator.go #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewoutp
added
Team Clifton
in progress
4 - Review
and removed
4 - Review
in progress
labels
matthewvon
reviewed
Jun 14, 2018
pkg/storage/pv_creator_test.go
Outdated
| func TestCreateNodeClientMap(t *testing.T) { | ||
| GB := int64(1024 * 1024 * 1024) | ||
| foo := mocks.NewProvisioner("foo", 100*GB, 100*GB) | ||
| bar := mocks.NewProvisioner("bar", 100*GB, 100*GB) |
There was a problem hiding this comment.
trivial: my preference would be to have four different values instead of 100*GB for all. What if you happen to have one of parameters backwards some place in the code?
matthewvon
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #162 (comment)