Skip to content

Conversation

@ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Jun 12, 2018

Functions of MemberStatusList that modify the list itself are dangerous when called outside the direct context of DeploymentStatusMembers.
This PR hides those functions and exposes them on DeploymentStatusMembers.

Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 5e3b732 into master Jun 12, 2018
@ewoutp ewoutp deleted the improvement/code-hiding branch June 12, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants