Skip to content

Conversation

@ajanikow
Copy link
Collaborator

@ajanikow ajanikow commented Nov 6, 2025

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 6, 2025
@ajanikow ajanikow requested a review from Copilot November 6, 2025 21:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the license member selection logic to support different server groups based on the license mode. The key change makes updateClusterLicenseMember accept server groups as a parameter instead of hardcoding them, enabling the API license mode to correctly use the serving group for license generation.

  • Refactored updateClusterLicenseMember to accept variadic groups parameter for flexibility
  • Updated updateClusterLicenseKey to pass GroupsWithLicenseV2() explicitly
  • Updated updateClusterLicenseAPI to use spec.Mode.ServingGroup() for proper serving group selection

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/deployment/reconcile/plan_builder_license.go Refactored updateClusterLicenseMember to accept server groups as parameter and updated callers to pass appropriate groups based on license mode
CHANGELOG.md Added bugfix entry for ensuring inventory uses the serving group for license generation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ajanikow ajanikow requested a review from Copilot November 6, 2025 21:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ajanikow ajanikow merged commit 2c2c332 into master Nov 6, 2025
8 of 9 checks passed
@ajanikow ajanikow deleted the bugfix/platform/use_serving_group branch November 6, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants