Skip to content

Conversation

@ajanikow
Copy link
Collaborator

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 15, 2025
@ajanikow ajanikow requested a review from Copilot November 15, 2025 18:15
Copilot finished reviewing on behalf of ajanikow November 15, 2025 18:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kubectl create secret generic arango-license-key --from-literal=token-v2="<license-string>"

# For the License Manager Key
kubectl create secret generic arango-license-key --from-literal=license-client-id="<license-client-id>" --from-literal=license-client-secret="<license-client-secret>"
Copy link

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples for both license key types use the same secret name arango-license-key. This will cause a conflict if users try to create both secrets. Consider using different secret names (e.g., arango-license-key and arango-license-manager-key) or clarifying that only one should be used at a time.

Suggested change
kubectl create secret generic arango-license-key --from-literal=license-client-id="<license-client-id>" --from-literal=license-client-secret="<license-client-secret>"
kubectl create secret generic arango-license-manager-key --from-literal=license-client-id="<license-client-id>" --from-literal=license-client-secret="<license-client-secret>"

Copilot uses AI. Check for mistakes.
Comment on lines +13 to +17
# For the License Key
kubectl create secret generic arango-license-key --from-literal=token-v2="<license-string>"

# For the License Manager Key
kubectl create secret generic arango-license-key --from-literal=license-client-id="<license-client-id>" --from-literal=license-client-secret="<license-client-secret>"
Copy link

Copilot AI Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples for both license key types use the same secret name arango-license-key. This will cause a conflict if users try to create both secrets. Consider using different secret names (e.g., arango-license-key and arango-license-manager-key) or clarifying that only one should be used at a time.

Copilot uses AI. Check for mistakes.
@ajanikow ajanikow merged commit b690631 into master Nov 15, 2025
8 of 9 checks passed
@ajanikow ajanikow deleted the feature/platform/optional_lm_install branch November 15, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants